Add a global setting to set a mapbox access token #7849
Labels
Comments
abey79
added
ui
|
it is not just a Mapbox token; we can easily add Google Bing, or other map providers - most need tokens for access. (I believe what you eventually need is some sort of centralized secret management.) |
6 tasks
abey79
added a commit
that referenced
this issue
Nov 6, 2024
### What This PR: - removes the `Options` submenu and replace it with a full-window "Settings" screen - moves the `Restart with WebGPU/WebGL` menu item to the top-level in the rerun menu (wasm only) - add a field for the Mapbox access token in the settings - fixes #7849 <img width="1265" alt="image" src="https://github.com/user-attachments/assets/f55ce903-d1e9-4cb1-b229-512c8958a5e5"> <br/><br/> Web viewer: <img width="246" alt="image" src="https://github.com/user-attachments/assets/c7d53cf0-00d2-41de-8ddd-9a19b7143834"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8001?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8001?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/8001) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#6561 adds a new map view to rerun. In order to enable mapbox as background, a mapbox token must be provided. Initially, it's done via the
RERUN_MAPBOX_ACCESS_TOKEN, but that setting should be editable from the UI and persisted with the rest of the app settings.The text was updated successfully, but these errors were encountered: