Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the "Options" submenu with a settings screen #8001

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 5, 2024

What

This PR:

  • removes the Options submenu and replace it with a full-window "Settings" screen
  • moves the Restart with WebGPU/WebGL menu item to the top-level in the rerun menu (wasm only)
  • add a field for the Mapbox access token in the settings
  • fixes Add a global setting to set a mapbox access token #7849
image



Web viewer:

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog feat-map-view Everything related to the map view labels Nov 5, 2024
@abey79 abey79 marked this pull request as ready for review November 5, 2024 16:22
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great!

@abey79 abey79 merged commit b963e50 into main Nov 6, 2024
42 checks passed
@abey79 abey79 deleted the antoine/settings-screen branch November 6, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-map-view Everything related to the map view include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a global setting to set a mapbox access token
2 participants