Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume real-world meters instead of UI unit for "scene unit" Radius values #7872

Closed
Tracked by #7877
abey79 opened this issue Oct 23, 2024 · 0 comments · Fixed by #8015
Closed
Tracked by #7877

Assume real-world meters instead of UI unit for "scene unit" Radius values #7872

abey79 opened this issue Oct 23, 2024 · 0 comments · Fixed by #8015
Labels
feat-map-view Everything related to the map view ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Oct 23, 2024

That would make it consistent with our definition of Radius and how it's used in the 2D view.

Would be facilitated by:
@abey79 abey79 added ui concerns graphical user interface feat-map-view Everything related to the map view labels Oct 23, 2024
@abey79 abey79 changed the title Positive radii should be interpreted in meters instead of UI units in the map view Assume real-world meters instead of UI unit for "scene unit" Radius values Oct 23, 2024
@abey79 abey79 mentioned this issue Oct 23, 2024
Closed
27 tasks
@abey79 abey79 mentioned this issue Nov 6, 2024
Merged
6 tasks
abey79 added a commit that referenced this issue Nov 6, 2024
@abey79
Bump walkers to 0.28 (#8011)
44501bd 
### What

- fix crash when zooming out
- add proper scroll/pan controls
- unblocks #7872

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8011?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8011?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/8011)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@abey79 abey79 mentioned this issue Nov 6, 2024
Merged
6 tasks
@abey79 abey79 closed this as completed in d25133a Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat-map-view Everything related to the map view ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for scene units in the map view rerun-io/rerun
1 participant
@abey79