Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scene units in the map view #8015

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 6, 2024

What

Add support for scene units (aka meter) in the map view.

map_scene_units.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view do-not-merge Do not merge this PR labels Nov 6, 2024
@abey79 abey79 marked this pull request as ready for review November 6, 2024 10:21
@abey79 abey79 force-pushed the antoine/map-view-scene-units branch from 2faf11a to 2d1a2ef Compare November 6, 2024 10:30
@Wumpf Wumpf self-requested a review November 6, 2024 10:45
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@abey79 abey79 mentioned this pull request Nov 6, 2024
27 tasks
Base automatically changed from antoine/linestrip to main November 7, 2024 14:59
@abey79 abey79 force-pushed the antoine/map-view-scene-units branch from 2d1a2ef to c8a059b Compare November 7, 2024 15:07
@abey79 abey79 removed the do-not-merge Do not merge this PR label Nov 7, 2024
@abey79 abey79 merged commit d25133a into main Nov 7, 2024
43 of 45 checks passed
@abey79 abey79 deleted the antoine/map-view-scene-units branch November 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assume real-world meters instead of UI unit for "scene unit" Radius values
2 participants