The scene unit radius of a GeoLineStrings only considers the first vertex' latitude
#8013
Labels
Comments
abey79
added
🪳 bug
|
Relevant slack thread: https://rerunio.slack.com/archives/C04NHBVF797/p1730885192012789 |
6 tasks
abey79
added a commit
that referenced
this issue
Nov 7, 2024
### What - Fixes #7872 - Limitation: #8013 Add support for scene units (aka meter) in the map view. https://github.com/user-attachments/assets/012c86d7-70cd-4144-9e54-414570ca286e ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8015?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8015?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/8015) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the map view, scene units are defined as meters. The corresponding screen space point size depends on the current zoom level and the latitude of the corresponding vertex. For
GeoLineStrings, we currently only consider the first vertex's latitude. This means that the screen space radius is wrong for all other vertices, unless they share the same latitude.For all intents and purposes, this doesn't matter for everything up to city-scale. However, at larger scales the scene units representation on
GeoLineStringscan be highly inaccurate because of this.The text was updated successfully, but these errors were encountered: