Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook cell times out on firefox #8154

Closed
jleibs opened this issue Nov 14, 2024 · 1 comment · Fixed by #8426
Closed

Notebook cell times out on firefox #8154

jleibs opened this issue Nov 14, 2024 · 1 comment · Fixed by #8426
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Milestone
Next patch release

Comments

@jleibs
Copy link
Member

jleibs commented Nov 14, 2024

This appears to be a regression between 0.19.1 and 0.20.0
@jleibs jleibs added 🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release labels Nov 14, 2024
@jleibs jleibs added this to the Next patch release milestone Nov 14, 2024
@jleibs
Copy link
Member Author

jleibs commented Dec 11, 2024

From: https://developer.mozilla.org/en-US/docs/Web/URI/Schemes/data
Firefox version 97 and newer supports data URLs of up to 32MB (before 97 the limit was close to 256MB)

Incidentally: 0.19.1 had a size of 24MB, and with the 33% overhead of base64 encoding came in at 31.9MB

0.20.0 ballooned to 27MB (36MB encoded).

@jleibs jleibs mentioned this issue Dec 11, 2024
Merged
jleibs added a commit that referenced this issue Dec 12, 2024
@jleibs
Fix broken notebook loading on firefox by compressing the encoded was…
e1aea95 
…m payload (#8426)

### Related
- Resolves: #8154

### What
It turns out firefox doesn't let you create a dataurl larger than 32MB.
Although our `.wasm` was under this threshold, the overhead of
base64-encoding pushed us over the threshold.

However, as we were encoding the raw, uncompressed .wasm, we still
actually have plenty of margin... we just need to jump through more
hoops to use it now. Using DecompressionStream like this seems to be
generally available across our target browsers so I think we should be
good?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
Next patch release
Development

Successfully merging a pull request may close this issue.

Fix broken notebook loading on firefox by compressing the encoded wasm payload rerun-io/rerun
1 participant
@jleibs