Fix broken notebook loading on firefox by compressing the encoded wasm payload #8426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
changed the title
|
Web viewer failed to build.
Note: This comment is updated whenever you push a commit. |
jleibs
force-pushed
the
jleibs/compress_notebook_wasm
branch
from
682ba20 to
1aaca2c
Compare
|
For posterity, there's some docs about it here: https://developer.mozilla.org/en-US/docs/Web/URI/Schemes/data#length_limitations |
jprochazk
approved these changes
Dec 12, 2024
jprochazk
reviewed
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
It turns out firefox doesn't let you create a dataurl larger than 32MB. Although our
.wasmwas under this threshold, the overhead of base64-encoding pushed us over the threshold.However, as we were encoding the raw, uncompressed .wasm, we still actually have plenty of margin... we just need to jump through more hoops to use it now. Using DecompressionStream like this seems to be generally available across our target browsers so I think we should be good?