Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-selection selection panel reborn #8336

Closed
abey79 opened this issue Dec 6, 2024 · 1 comment · Fixed by #8351
Closed

Multi-selection selection panel reborn #8336

abey79 opened this issue Dec 6, 2024 · 1 comment · Fixed by #8351
Assignees
@emilk
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Dec 6, 2024

Context

The current implementation of the selection panel is comically useless when multiple items are selected, and incurs undue code complexity (e.g. UiLayout::SelectionPanelLimitHeight). For the longest time, our dream has been to come up with some "merged" view of the current selection, but this hardly is actionable as a starting point:

Proposal

This issue is about getting the ball rolling on this front with a two-step, actionable, minimalistic take on the selection panel with multi-selection:

  1. show a list of what is currently selected
  2. ...and that's basically it
@abey79 abey79 added the ui concerns graphical user interface label Dec 6, 2024
@emilk emilk self-assigned this Dec 6, 2024
@emilk
Copy link
Member

emilk commented Dec 6, 2024

Current attempt:
Image

@emilk emilk mentioned this issue Dec 8, 2024
Merged
emilk added a commit that referenced this issue Dec 9, 2024
@emilk
More compact selection panel when multiple items selected (#8351)
d69fbc6 
### Related
* Closes #8336

### What
When you have more than one item selected at once, you get a list of all
items. Clicking one will select just that.

<img width="308" alt="multiple-selected-entities"
src="https://github.com/user-attachments/assets/67174eed-373a-486c-a2b1-b97a08136805">

### Implementation
A bit messy, to be honest. I leveraged the existing `ItemTitle` for some
items, and hand-rolled others.

It would be nice with something similar to `DataUi`, but for titles
(with or without breadcrumbs).

But the amount of messy code is low and low-impact, so unless someone
has a good suggestion or strongly objects, I suggestion calling this
"good enough for now".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More compact selection panel when multiple items selected rerun-io/rerun
2 participants
@emilk @abey79