-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More compact selection panel when multiple items selected #8351
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
I like it otherwise but this is quite the step backwards for interacting with objects in 2d views with images :/ |
I believe you are referring to the problem outlined in this issue: Clicking e.g. a point in a 2D view would also select all images below the point: -> With this PR, the same click now produces this selection panel: The old behavior was already really bad, imho. Why would clicking a point select the image behind the point? That's just a bug imho. Clicking two translucent images is arguably different. But is it really better to get a list of expanded items, forcing you to scroll, or to show a concise list of things under the mouse, prompting you to refine the selection with a second click? |
Is it though? Sure you need one more click to inspect that point/box2d thing. But the entire process makes so much more sense now. Click places -> stuff there is shown to me -> can make educated choice on what really is of interest. That being said, images are generally very easy to select by themselves, so I wouldn't be against filtering them out of any picking multi-selection. edit: see my comment here: #6761 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Related
What
When you have more than one item selected at once, you get a list of all items. Clicking one will select just that.
Implementation
A bit messy, to be honest. I leveraged the existing
ItemTitle
for some items, and hand-rolled others.It would be nice with something similar to
DataUi
, but for titles (with or without breadcrumbs).But the amount of messy code is low and low-impact, so unless someone has a good suggestion or strongly objects, I suggestion calling this "good enough for now".