Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clicking and hovering various views #8479

Closed
grtlr opened this issue Dec 16, 2024 · 1 comment · Fixed by #8495
Closed

Fix clicking and hovering various views #8479

grtlr opened this issue Dec 16, 2024 · 1 comment · Fixed by #8495
Labels
🪳 bug Something isn't working ui concerns graphical user interface

Comments

@grtlr
Copy link
Contributor

grtlr commented Dec 16, 2024 •
edited
Loading

Fix clicking and hovering for the following views (they should highlight correctly):
@grtlr grtlr added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working ui concerns graphical user interface and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Dec 16, 2024
@nikolausWest nikolausWest mentioned this issue Dec 16, 2024
Closed
@teh-cmc
Copy link
Member

teh-cmc commented Dec 16, 2024

Please update check_hover_select_reset.py while you're at it!

This was referenced Dec 17, 2024
Closed
Merged
grtlr added a commit that referenced this issue Dec 17, 2024
@grtlr
Add missing click and hover interactions for views (#8495)
a7acf15 
### Related

<!--
Include links to any related issues/PRs in a bulleted list, for example:
* Closes #1234
* Part of #1337
-->

* Closes #8479
* Closes #5138

### What

This adds missing view interactions the following views:

* Map view
* Graph view
* TextDocument view

@Wumpf @abey79 I feel like the pattern repeats itself and it's easy to
miss when writing new views. So I wonder if this could be unified. I see
several options for this:

* repurpose `handle_select_hover_drag_interactions` which only seems to
be used for `DataResult` right now
* Making each view return a `Result<(Response,
ViewSystemExecutionError>` (instead of `()`) and handling it outside of
the view.
* Creating a function analogous to
`handle_select_hover_drag_interactions`.

<!--
Make sure the PR title and labels are set to maximize their usefulness
for the CHANGELOG,
and our `git log`.

If you have noticed any breaking changes, include them in the migration
guide.

We track various metrics at <https://build.rerun.io>.

For maintainers:
* To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
* To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing click and hover interactions for views rerun-io/rerun
2 participants
@teh-cmc @grtlr