-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 2d heuristic -- split any bucket with more than 1 image #5148
Conversation
39a0942
to
d8f6b06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code confuses me, but if it makes all the test go green I don't want it holding up the release.
running Notice that the top right viewport has a huge 2D image in a 3D viewport Hitting "reset viewport" fixes it. |
I suggest we remove objectron from the default example list. |
What
I decided that if images are nested then we should still stack them when bucketed.
However, if multiple images are logged as siblings (or other non-nested hierarchies), they should get their own reviews.
The basic logic is as follows:
Checklist
main
build: app.rerun.ionightly
build: app.rerun.ioExtra checklist