Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 2d heuristic -- split any bucket with more than 1 image #5148

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 8, 2024

What

I decided that if images are nested then we should still stack them when bucketed.
However, if multiple images are logged as siblings (or other non-nested hierarchies), they should get their own reviews.

The basic logic is as follows:

  • Bucket the images.
  • If the root of the bucket is an image (i.e. the contents are nested image) then use it.
  • Otherwise, check to see if there is more than 1 non-nested image or non-nested depth-image. (We allow multiple segmentation images to layer). If there aren't we return it.
  • If yes, then split the bucket and recurse.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

Extra checklist

  • Reset viewer and test all nightly examples

@jleibs jleibs added 📺 re_viewer affects re_viewer itself include in changelog labels Feb 8, 2024
@jleibs jleibs marked this pull request as ready for review February 8, 2024 19:57
@jleibs jleibs force-pushed the jleibs/image_bucket_tweaks branch from 39a0942 to d8f6b06 Compare February 8, 2024 19:58
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code confuses me, but if it makes all the test go green I don't want it holding up the release.

crates/re_space_view_spatial/src/space_view_2d.rs Outdated Show resolved Hide resolved
crates/re_space_view_spatial/src/space_view_2d.rs Outdated Show resolved Hide resolved
@emilk
Copy link
Member

emilk commented Feb 9, 2024

running cargo rerun reset && cargo rerun and clicking on Objectron sometimes leads to this pretty broken state:

image

Notice that the top right viewport has a huge 2D image in a 3D viewport

Hitting "reset viewport" fixes it.

@emilk
Copy link
Member

emilk commented Feb 9, 2024

I suggest we remove objectron from the default example list.

@emilk emilk merged commit 563fae5 into main Feb 9, 2024
41 of 42 checks passed
@emilk emilk deleted the jleibs/image_bucket_tweaks branch February 9, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging images to different child-of-root entity paths should result in separate SpaceViews
2 participants