Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate first-frame heuristics for our default examples #5156

Open
emilk opened this issue Feb 9, 2024 · 1 comment
Open

Investigate first-frame heuristics for our default examples #5156

emilk opened this issue Feb 9, 2024 · 1 comment
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples heuristics Heuristics for placing views, fallback provider, etc.

Comments

@emilk
Copy link
Member

emilk commented Feb 9, 2024

cargo rerun reset, then open objectron over a slow internet connection, and you sometimes get this:

image

As 3D spaceview with a 2D image in it.

Most of the time though I "just" end up with this:

image

A weird extra space-view, taking up most of the screen.


It would be nice with a way to test all our examples on a slow connection, to find weird first-frame heuristic issues.

@emilk emilk added 🪳 bug Something isn't working examples Issues relating to the Rerun examples heuristics Heuristics for placing views, fallback provider, etc. labels Feb 9, 2024
@emilk emilk changed the title Objectron sometimes has bad first-frame heuristics Investigate first-frame heuristics for our default examples Feb 9, 2024
emilk added a commit that referenced this issue Feb 9, 2024
### What
The first-frame heuristics of objectron sometimes produce really bad
results:


![image](https://github.com/rerun-io/rerun/assets/1148717/99561a46-38cd-4c4d-8a65-b793b1be79bf)

(top-right corner is a 3D view with 2D elements in it).

In the interest of getting a release out today, and not giving first
users a bad impression, this PR removes Objectron from the example page.
It is not a very pretty example anyway.

### Related issues
* #5156
* #5154

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5155/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5155/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5155/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5155)
- [Docs
preview](https://rerun.io/preview/49097fb6d0b36ac10840101262e5a4b6abb87ca4/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/49097fb6d0b36ac10840101262e5a4b6abb87ca4/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf
Copy link
Member

Wumpf commented Feb 12, 2024

I believe the concrete issue is fixed by

Since the 2D heuristic then very rarely suggests /

Overall related to:

I think there's an even higher level issue of the heuristic right now not being able to touch existing views, all we do is additive and this causes a lot of issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples heuristics Heuristics for placing views, fallback provider, etc.
Projects
None yet
Development

No branches or pull requests

2 participants