Refactor the 2D heuristic again #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
heuristics
emilk
reviewed
Feb 12, 2024
Wumpf
approved these changes
Feb 12, 2024
Comment on lines
+18
to
+32
| impl MaxImageDimensions { | ||
| /// Accesses the image dimension information for a given store | ||
| pub fn access<T>( | ||
| store_id: &StoreId, | ||
| f: impl FnOnce(&IntMap<EntityPath, ImageDimensions>) -> T, | ||
| ) -> Option<T> { | ||
| re_data_store::DataStore::with_subscriber_once( | ||
| MaxImageDimensionSubscriber::subscription_handle(), | ||
| move |subscriber: &MaxImageDimensionSubscriber| { | ||
| subscriber.max_dimensions.get(store_id).map(|v| &v.0).map(f) | ||
| }, | ||
| ) | ||
| .flatten() | ||
| } | ||
| } |
There was a problem hiding this comment.
so annoying to ahve to repeat this boilerplate. Store subscriber needs a builtin layer for this...
Wumpf
force-pushed
the
jleibs/heuristic_image_splits
branch
from
dad4aee to
015ba75
Compare
Wumpf
force-pushed
the
jleibs/heuristic_image_splits
branch
from
bf16bd5 to
da9a0d2
Compare
|
testing with opf --no-frames: spawn_heuristics for 2D costs me 0.13ms on release, so definitly got slower. Not amazing but don't care about this overhead right now. Interestingly we got quite heavy losses in property heuristics. whopping 1.2ms, but this wasn't this PR and it's not critical at this point |
Wumpf
added a commit
that referenced
this pull request
Feb 12, 2024
### What - Builds on top of #5164 Adds a store subscriber for tracking the dimensions of image entities. Gets rid of the previous bucketing logic and replaces it with a new implementation that starts at the top of the subspace and incrementally splits when it finds conflicting image entities within the space. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5166/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5166/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5166/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5166) - [Docs preview](https://rerun.io/preview/da9a0d206235016d14d9826e8c42ed8481d29643/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/da9a0d206235016d14d9826e8c42ed8481d29643/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Andreas Reich <r_andreas2@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a store subscriber for tracking the dimensions of image entities.
Gets rid of the previous bucketing logic and replaces it with a new implementation that starts at the top of the subspace and incrementally splits when it finds conflicting image entities within the space.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io