Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Objectron from default examples #5155

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 9, 2024

What

The first-frame heuristics of objectron sometimes produce really bad results:

image

(top-right corner is a 3D view with 2D elements in it).

In the interest of getting a release out today, and not giving first users a bad impression, this PR removes Objectron from the example page. It is not a very pretty example anyway.

Related issues

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added the examples Issues relating to the Rerun examples label Feb 9, 2024
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷🏻

@emilk emilk added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Feb 9, 2024
@emilk emilk merged commit 01c8f3b into main Feb 9, 2024
40 of 45 checks passed
@emilk emilk deleted the emilk/remove-objectron-from-default-examples branch February 9, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants