Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example visualizing RRT* #5214

Merged
merged 14 commits into from
Feb 23, 2024
Merged

Add example visualizing RRT* #5214

merged 14 commits into from
Feb 23, 2024

Conversation

02alexander
Copy link
Collaborator

@02alexander 02alexander commented Feb 16, 2024

What

Adds an python example that visualizes the RRT* pathfinding algorithm. There isn't a screenshot of the viewer in the README.md yet but it will be added by linking to the image in this pull request.
I have tested the example in the native viewer in and the web viewer but I'm not sure if that's what "[ ] I have tested the web demo" means.

rrt-star-screenshot

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@02alexander 02alexander added the examples Issues relating to the Rerun examples label Feb 16, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 🤩

@02alexander 02alexander added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Feb 16, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no Python coder, but looks good to me!

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking cool, but I for one need more docs!

examples/python/rrt-star/main.py Outdated Show resolved Hide resolved
examples/python/rrt-star/main.py Show resolved Hide resolved
@Wumpf
Copy link
Member

Wumpf commented Feb 16, 2024

I have tested the example in the native viewer in and the web viewer but I'm not sure if that's what "[ ] I have tested the web demo" means.

This is only relevant for changes to the viewer and api. We usually want to make sure that the online web demo the ci builds still works with those changes. For a new example you can ignore this :)

@02alexander
Copy link
Collaborator Author

The link to the screenshot of the example seems to be acting weird. I don't have gcloud access yet so I can't use just upload. So I tried linking to the images I uploaded in this PR but it's looks like the urls are changing.

@02alexander 02alexander requested a review from Wumpf February 21, 2024 17:22
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, much better

@02alexander 02alexander merged commit d7ef517 into main Feb 23, 2024
@02alexander 02alexander deleted the alexander/rrt-star-example branch February 23, 2024 09:47
@Wumpf Wumpf added include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants