-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create matching benchmarks for the arrow datastore #582
Conversation
5e2338b
to
53dfd61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to finally get these in!
#[cfg(not(debug_assertions))] | ||
const NUM_FRAMES: u32 = 100; | ||
#[cfg(not(debug_assertions))] | ||
const NUM_POINTS: u32 = 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in crates/re_data_store/benches/obj_query_benchmark.rs
we use 1000 for both these. I guess arrow is still too slow for that?
It would be nice to have matching numbers so we can compare apples to apples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup -- this is coming as soon as we land #582
.into_iter() | ||
.map(move |point_idx| obj_path!("points", Index::Sequence(point_idx as _))) | ||
.collect_vec(); | ||
let msgs = build_messages(&paths, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated, but message encoding/decoding is another thing we would like to benchmark!
If these look terrifying, don't panic. Improvements are coming in a followup PR:
Resolves: #575
Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)