ComponentFallbackProvider and greatly simplified edit_ui
#6465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider` & `ComponentFallbackProvider`
Wumpf
added
ui
emilk
approved these changes
May 31, 2024
Comment on lines
+46
to
+48
| value: &mut ScalarScattering, | ||
| ) -> egui::Response { | ||
| let scattered_text = if value.0 { "Scattered" } else { "Line" }; |
There was a problem hiding this comment.
Unrelated to this PR, but this highlights that ScalarScattering should probably been an enum instead (it was created before we had enum support in codegen)
There was a problem hiding this comment.
👍
worth breaking the api (now is a good time!) taking it in a followup!
There was a problem hiding this comment.
oh wait that thing is so old, we stopped using it :O
5 tasks
Wumpf
added a commit
that referenced
this pull request
Jun 3, 2024
### What ... and use that to further simplify edit ui using this (that part is a refactor though, the title line is the user facing change here :)) * this addresses a comment on #6465 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6470?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6470?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6470) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
initial_override_valuewith a "FallbackProvider" trait which can be used for edit_ui #6434Two major intertwined changes:
ComponentFallbackProviderreplacesinitial_override_value(motivation see ticket)Things to be iterated on:
UiLayoutin that case? cc: @abey79QueryContexthas a bold name but is only used on the fallback provider right now and lacks some context that we'll need for upcoming fallback provider impls (view state etc.!)All of these will end up being part of
DataResult#6435Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.