Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen DerefMut & Deref for all trivial components #6470

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Codegen DerefMut & Deref for all trivial components #6470

merged 6 commits into from
Jun 3, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 31, 2024 •
edited
Loading

What

... and use that to further simplify edit ui using this (that part is a refactor though, the title line is the user facing change here :))

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added ui concerns graphical user interface 🦀 Rust API Rust logging API codegen/idl include in changelog labels May 31, 2024
@Wumpf Wumpf mentioned this pull request May 31, 2024
Merged
5 tasks
@Wumpf Wumpf force-pushed the andreas/derefmut-codegen branch from 2485882 to 251b5fb Compare May 31, 2024 11:44
@teh-cmc teh-cmc self-requested a review June 3, 2024 07:23
teh-cmc
teh-cmc approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had pretty bad experiences with blanket implementations of Deref in the past... let's hope this one becomes the exception 🙏

crates/re_edit_ui/src/datatype_editors/singleline_string.rs
edit_singleline_string_impl(ui, value)
}

/// Non monomorphized implementation of [`edit_singleline_string`].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to do that everywhere... or rather, the compiler should 😒

crates/re_types_builder/src/codegen/rust/api.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit ee80b7b into main Jun 3, 2024
8 of 19 checks passed
@Wumpf Wumpf deleted the andreas/derefmut-codegen branch June 3, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
codegen/idl include in changelog 🦀 Rust API Rust logging API ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @teh-cmc