Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose FillRatio component to configure DepthImage backprojection radius scaling #6566

Merged
merged 10 commits into from
Jun 14, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 13, 2024

What

Introduces FillRatio component. Example:

rr.log("world/camera/depth", rr.DepthImage(depth_image, meter=10_000.0, backproject_radius_scale=0.2))

Works as before:
image

Based on #6558 to avoid conflicts

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added do-not-merge Do not merge this PR 🍏 primitives Relating to Rerun primitives include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Jun 13, 2024
Copy link

github-actions bot commented Jun 13, 2024

Deployed docs

Commit Link
866457e https://landing-adwkshask-rerun.vercel.app/docs

docs/snippets/all/archetypes/depth_image_3d.py Outdated Show resolved Hide resolved
Base automatically changed from andreas/timeseriesaggregator-component to main June 14, 2024 09:44
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jun 14, 2024
@Wumpf Wumpf force-pushed the andreas/backprojection-size-factor branch from 5f89559 to 5bbf3fd Compare June 14, 2024 09:50
@Wumpf Wumpf merged commit d35e3ab into main Jun 14, 2024
5 of 9 checks passed
@Wumpf Wumpf deleted the andreas/backprojection-size-factor branch June 14, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🍏 primitives Relating to Rerun primitives
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants