TimeSeriesAggregation can now be set per SeriesLine (and as blueprint default per View) #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🍏 primitives
Deployed docs
|
5 tasks
Wumpf
added a commit
that referenced
this pull request
Jun 13, 2024
### What And add a colormap edit ui - this allows to use colormap in overrides/defaults and makes it visible when logged: Before: <img width="302" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/1b79b6c8-e441-4cc2-87a9-fc89282a1a84"> After: <img width="303" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/c44c720c-3b89-4eee-b2f8-468d4eb5af9b"> Discovered while working on #6558 which had the same issue. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6559?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6559?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6559) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
…regator-component
5 tasks
jleibs
approved these changes
Jun 13, 2024
Wumpf
added a commit
that referenced
this pull request
Jun 14, 2024
…adius scaling (#6566) ### What Introduces `FillRatio` component. Example: ```python rr.log("world/camera/depth", rr.DepthImage(depth_image, meter=10_000.0, backproject_radius_scale=0.2)) ``` * Almost done with #5067 * This was the last legacy property to blueprintify! * Only the actual cleanup is missing. Some of it already creeped in here since clippy noticed the cascade of unused things, but I went only as far as I had to to make it happy to keep this PR sane Works as before: <img width="1167" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/b564944b-c4a3-459a-a9a0-9692caeb5110"> Based on #6558 to avoid conflicts ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [ ] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6566?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6566?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6566) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
TimeSeriesAggreationcomponent toSeriesLine, allowing to set it both per line and as a component default.example:
This is good step forward overall but there's problems with this PR
--
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.