Find a way to make common defaults more visible #6557
Labels
Comments
Wumpf
added
ui
Merged
5 tasks
Wumpf
added a commit
that referenced
this issue
Jun 14, 2024
… default per View) (#6558) ### What Adds `TimeSeriesAggreation` component to `SeriesLine`, allowing to set it both per line and as a component default. example: ```python rr.log("trig/sin", rr.SeriesLine(color=[255, 0, 0], name="sin(0.01t)", aggregator="minmax"), static=True) ``` This is good step forward overall but there's problems with this PR * ui is a bit worse #6556 * one would expect this setting still on the view since most of the time one wants to change the aggregation for all lines (i.e. the default): #6557 -- * Part of #4442 * If not already fixed, fixes #6460 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6558?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6558?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6558) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
|
This is addressed by the new override UI: #6605 |
|
closing until we think it's not visible enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should have a way to suggest changing certain component defaults per View.
Certain components are much more common candidates for overrides:
The tricky part is that we can't show a "current value" in all cases since generally, the current value is dependent on the exact dataresult (e.g. color fallback is implemented per visualizer and typically entity path dependent).
-> Either we limit ourself to components where we rely strictly on the placeholder (how to enforce?) or we somehow indicate that the default was not yet set.
The later is generally preferable since we want to be able to express what data is actually in the blueprint store, i.e. what blueprint has been sent from the code. If we were to show properties as-if a default was set, this makes the blueprint-code to viewer relationship quickly confusing!
I believe we want a ui that has the effect of “hey, hey! I'm a component that's cool to set as a default!" with neither showing the value nor indicating that it was already set 🤔
The text was updated successfully, but these errors were encountered: