-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split entity properties into separate components #4442
Labels
🟦 blueprint
The data that defines our UI
Comments
Merged
5 tasks
Wumpf
added a commit
that referenced
this issue
Jun 14, 2024
… default per View) (#6558) ### What Adds `TimeSeriesAggreation` component to `SeriesLine`, allowing to set it both per line and as a component default. example: ```python rr.log("trig/sin", rr.SeriesLine(color=[255, 0, 0], name="sin(0.01t)", aggregator="minmax"), static=True) ``` This is good step forward overall but there's problems with this PR * ui is a bit worse #6556 * one would expect this setting still on the view since most of the time one wants to change the aggregation for all lines (i.e. the default): #6557 -- * Part of #4442 * If not already fixed, fixes #6460 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6558?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6558?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6558) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
forgot to close this, it's doooone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
EntityProperties is currently a single serde-based mono-component:
For each of these fields, there should be a new, explicit component.
The text was updated successfully, but these errors were encountered: