Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce visualizer blueprint query stack ui #6605

Merged
merged 15 commits into from
Jun 24, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 20, 2024

What

The visualizer ui now shows the full stack of override/store/default/fallback and allows a wide variety with interaction with it.

Screen.Recording.2024-06-20.at.17.58.00.mov

There's a new "more" button which gives access to various options for setting the override or setting the view's default (feedback on what goes on those lines welcome
image

Furthermore, the "add" visualizer button is now part of the header section:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog labels Jun 20, 2024
@Wumpf Wumpf changed the title Introduce visualizer sensitive blueprint query stack ui Introduce visualizer blueprint query stack ui Jun 20, 2024
@abey79 abey79 self-requested a review June 24, 2024 07:58
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insane 🤩

crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
crates/re_ui/src/ui_ext.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
Comment on lines +188 to 197
let (value_source, raw_current_value) = match (
raw_override.as_ref(),
raw_store.as_ref(),
raw_default.as_ref(),
) {
(Some(override_value), _, _) => (ValueSource::Override, override_value.as_ref()),
(None, Some(store_value), _) => (ValueSource::Store, store_value.as_ref()),
(None, None, Some(default_value)) => (ValueSource::Default, default_value.as_ref()),
(None, None, None) => (ValueSource::FallbackOrPlaceholder, raw_fallback.as_ref()),
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own comprehension: this bit duplicates the logic of how things happen for real, but can't be DRYed because the actual logic is dispatched all over the place (with fallback providers, etc.). Correct?

Copy link
Member Author

@Wumpf Wumpf Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, correct.
The "for real" logic itself is unfortunately a bit cluttered and needs cleanup, something I already talked about with @jleibs. Luckily we arrived at this relatively simple stack. It would be still good to be able to unify this more, especially given how annotation context doesn't fit into this at all right now :/

@abey79
Copy link
Member

abey79 commented Jun 24, 2024

Also, I think this PR introduces a spurious horizontal scroll bar in the selection panel when a "large" viz component is displayed in the list:

image

Actually, it might be due to the header with "+" button, as the scroll bar is there even with an empty viz list:

image

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tooltips lgtm, fighting those forbidden periods ;)

crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit ef2dbad into main Jun 24, 2024
34 of 35 checks passed
@Wumpf Wumpf deleted the andreas/visualizer-ui-expanded branch June 24, 2024 16:41
abey79 added a commit that referenced this pull request Jun 25, 2024
### What

Improve `large_collapsing_header[_with_button]` with:
- text truncation when the available width is narrow
- fix sizing issue introduced in #6605 that would induce spurious
horizontal scrolling



https://github.com/rerun-io/rerun/assets/49431240/d298dc17-6065-4297-88b4-e0a67c20846c



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6622?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6622?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6622)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI for showing overrides and data sources
2 participants