Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help to several sections in the Selection Panel #6668

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Add help to several sections in the Selection Panel #6668

merged 3 commits into from
Jun 28, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jun 27, 2024 •
edited by Wumpf
Loading

What

Adds a bunch of help buttons to various sections in the selection panel, in particular for component default and visualisers.

image image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jun 27, 2024
@Wumpf Wumpf self-requested a review June 27, 2024 15:59
Wumpf
Wumpf requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visible time range text didn't stand the test of time!

great additions otherwise!

crates/re_selection_panel/src/defaults_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visible_time_range_ui.rs Outdated Show resolved Hide resolved
crates/re_selection_panel/src/visualizer_ui.rs
@@ -50,8 +50,27 @@ pub fn visualizer_ui(
.hover_text("Add additional visualizers")
.disabled_hover_text("No additional visualizers available");

let markdown = "# Visualizers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, love it! we can re-use some of this on the doc page we still haven't written on this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, these tooltip will very much benefit from links to the docs, when those exists.

Base automatically changed from antoine/refactor-item-button to main June 27, 2024 16:31
@abey79 abey79 force-pushed the antoine/section-help branch from 3c98dc8 to 23894e5 Compare June 27, 2024 16:32
@abey79 abey79 mentioned this pull request Jun 27, 2024
Closed
7 tasks
@abey79 abey79 requested a review from Wumpf June 28, 2024 06:44
@Wumpf Wumpf merged commit 914c9ec into main Jun 28, 2024
33 of 35 checks passed
@Wumpf Wumpf deleted the antoine/section-help branch June 28, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @Wumpf