-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file dialogs inside docker containers, improve file dialogs on web #6795
Conversation
Unfortunately this leads to a lot of duplicated dependencies, as you can see by running EDIT: it seems difficult to avoid pulling in |
I think the main problem is that rfd bumped its ashpd version from 0.6 to 0.8 in PolyMeilex/rfd@a88718e which in turn now requires zbus version 4.0. Sadly I couldn't find a way to reconcile the duplicate zbus dependency. But I'm also not really familar with Rust as a whole, maybe I'm just too dumb. EDIT: Nevermind, just saw your edit... Do you have an ETA on when emilk/egui#4437 will make it into egui and in turn into the Python rerun-sdk? |
No ETA on the We could consider living with the duplicated dependencies, but I'm not a big fan of the increased compilation times that will result in. |
No worries, maybe I can figure out a way to get rfd 0.12 with xdg-portal backend working inside my docker container after all. |
I wonder if this PR solves |
an update of winit has now landed on |
looks like accesskit didn't get updated on egui - the zbus dependency hasn't improved when merging, resetting cargo.lock to main and building |
|
The problem with access kit holding on to an old version unfortuantely persists
Given that this update also makes our save dialogs a lot better on the web, we surely can do some effort to fix the situation in accesskit @emilk ? fwiw, rfd is by now on version 0.15 |
The latest A single duplicate of |
### What While updating #6795, I noticed that cargo deny warned about our version of `futures-utils` being yanked. `cargo update -p futures-util` ran cleanly, no duplicated dependencies as a result ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7925?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7925?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7925) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
tried for a while, but it's a bit of a mess. There's other packages that are on 3.x.y zbus whereas other have moved on to 4.x.y. |
keeping the file dialog issue open since the confusing |
I'll tackle this in a new PR, together with a bunch of other cargo updates |
Fixes rfd file-dialogs not opening up inside Docker containers by bumping the rfd version to 0.14.1 which includes a zenity fallback that works inside Docker containers. See #6794 for more info.
What
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.