Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update futures util (and related) due to yanked crate #7925

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 29, 2024

What

While updating #6795, I noticed that cargo deny warned about our version of futures-utils being yanked. cargo update -p futures-util ran cleanly, no duplicated dependencies as a result

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 29, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Oct 29, 2024

ci says:

AssertionError: Some components are missing from the ALL_COMPONENTS dictionary: {'LengthBatch'}

wasn't me 🤷

@Wumpf Wumpf merged commit 8271c90 into main Oct 29, 2024
36 of 37 checks passed
@Wumpf Wumpf deleted the andreas/update-futures branch October 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants