Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for precisely picking an exact sequence time #7673

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 10, 2024

What

I only implemented it for sequence timelines for now, since I didn't want to parse timestamps in different formats this early in the morning. Hopefully this can still help @teh-cmc.

It also shows how to do it for temporal timelines if someone wants to follow my lead.

precise-time-control

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface include in changelog labels Oct 10, 2024
@teh-cmc teh-cmc self-requested a review October 10, 2024 07:25
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With realtime feedback and everything, sweet!

Nit: if you enter <static>, then the field becomes non-editable once again, which is a bit weird, but eh.

@emilk
Copy link
Member Author

emilk commented Oct 10, 2024

if you enter <static>, then the field becomes non-editable once again

So it becomes… static? 😆

@emilk emilk merged commit 8394dc9 into main Oct 10, 2024
36 checks passed
@emilk emilk deleted the emilk/jump-to-frame branch October 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants