Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC spec update: Add support for selecting specific columns while listing recordings metadata #8049

Merged
merged 7 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions crates/store/re_protos/proto/rerun/v0/remote_store.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,14 @@ package rerun.remote_store.v0;
import "rerun/v0/common.proto";

service StorageNode {
rpc ListRecordings(ListRecordingsRequest) returns (ListRecordingsResponse) {}
// data API calls
rpc Query(QueryRequest) returns (stream QueryResponse) {}
rpc FetchRecording(FetchRecordingRequest) returns (stream FetchRecordingResponse) {}

// metadata API calls
rpc ListRecordings(ListRecordingsRequest) returns (ListRecordingsResponse) {}
rpc GetRecordingMetadata(GetRecordingMetadataRequest) returns (GetRecordingMetadataResponse) {}
rpc UpdateRecordingMetadata(UpdateRecordingMetadataRequest) returns (UpdateRecordingMetadataResponse) {}
rpc RegisterRecording(RegisterRecordingRequest) returns (RegisterRecordingResponse) {}
}

Expand Down Expand Up @@ -67,6 +71,18 @@ message TimeMetadata {
TimeRange time_range = 2;
}

// ---------------- UpdateRecordingMetadata -----------------

message UpdateRecordingMetadataRequest {
RecordingId recording_id = 1;
RecordingMetadata metadata = 2;
}

message UpdateRecordingMetadataResponse {
RecordingId id = 1;
RecordingMetadata metadata = 2;
}

// ---------------- Query -----------------

message QueryRequest {
Expand All @@ -93,7 +109,16 @@ enum EncoderVersion {

// ----------------- ListRecordings -----------------

message ListRecordingsRequest {}
message ListRecordingsRequest {
// define which columns should be returned / projected
// we define a separate message to make it optional.
// If not provided, all columns should be returned
ColumnProjection column_projection = 1;
}

message ColumnProjection {
repeated string columns = 1;
}

message ListRecordingsResponse {
repeated RecordingMetadata recordings = 1;
Expand Down
Loading
Loading