Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate JSX 3 #7042

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Deprecate JSX 3 #7042

merged 4 commits into from
Sep 20, 2024

Conversation

mununki
Copy link
Member

@mununki mununki commented Sep 19, 2024

resolved #6982

Deprecate JSX 3 from v11

image

@mununki
Copy link
Member Author

mununki commented Sep 19, 2024

@cknitt Should we put @deprecated on all the values of the V3 module of rescript-relay as well? What do you think?

@cknitt
Copy link
Member

cknitt commented Sep 19, 2024

@mununki Thanks a lot! 👍

As 11.1.4 is out already, could you put the changelog entry under a new section

# 11.1.5 (Unreleased)

?

As for rescript-relay, let's ask @zth as that is his baby. 🙂

@zth
Copy link
Collaborator

zth commented Sep 19, 2024

I think you mean @rescript/react, right? 🙈

@mununki
Copy link
Member Author

mununki commented Sep 20, 2024

I think you mean @rescript/react, right? 🙈

Oops, my bad. I was always thinking about rescript-relay, so I made a mistake. 😉

@mununki
Copy link
Member Author

mununki commented Sep 20, 2024

@mununki Thanks a lot! 👍

As 11.1.4 is out already, could you put the changelog entry under a new section

# 11.1.5 (Unreleased)

?

As for rescript-relay, let's ask @zth as that is his baby. 🙂

It was typo, I meant rescript-react.

@cknitt
Copy link
Member

cknitt commented Sep 20, 2024

It was typo, I meant rescript-react.

Ah, sorry!

Yes, that makes sense. Could you create a PR there, too?

@cknitt cknitt merged commit 5b9d693 into 11.0_release Sep 20, 2024
14 checks passed
@cknitt cknitt deleted the deprecated-jsx-3 branch September 20, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants