Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve organisation dedup RSD/ROR #405

Closed
dmijatovic opened this issue Jul 12, 2022 · 0 comments · Fixed by #434
Closed

Improve organisation dedup RSD/ROR #405

dmijatovic opened this issue Jul 12, 2022 · 0 comments · Fixed by #434
Assignees
@dmijatovic
Labels
bug Something isn't working
Milestone
Milestone 7: Real...

Comments

@dmijatovic
Copy link
Contributor

dmijatovic commented Jul 12, 2022 •
edited
Loading

When searching for an organisation the same organisation could be shown twice using RSD or ROR as source. The current key is slug based on organisation name and it causes some errors in the console

image
@dmijatovic dmijatovic added the bug Something isn't working label Jul 12, 2022
@dmijatovic dmijatovic added this to the Milestone 7 milestone Jul 12, 2022
@dmijatovic dmijatovic self-assigned this Jul 12, 2022
dmijatovic added a commit that referenced this issue Jul 24, 2022
@dmijatovic
fix: #405 use ror_id as primary key for dedup
5f9bae1
@dmijatovic dmijatovic mentioned this issue Jul 24, 2022
Merged
4 tasks
@dmijatovic dmijatovic mentioned this issue Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmijatovic dmijatovic

Labels
bug Something isn't working
Projects
None yet
Milestone
Milestone 7: Real users
Development

Successfully merging a pull request may close this issue.

428 project fixes research-software-directory/RSD-as-a-service
1 participant
@dmijatovic