Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UU organization name dependency: duplicated entry? #531

Closed
bakhshir opened this issue Sep 20, 2022 · 7 comments · Fixed by #537
Closed

UU organization name dependency: duplicated entry? #531

bakhshir opened this issue Sep 20, 2022 · 7 comments · Fixed by #537
Assignees

Comments

@bakhshir
Copy link

Weird issue: depending on how i try to add Utrecht University to participating organizations, RSD gives me different results.

If I type University of Utrecht,
Screenshot from 2022-09-20 10-58-22

this is what i get even if i choose proper ROR entry:
Screenshot from 2022-09-20 10-47-08

If I type Utrecht University, I get the proper entry with the logo:
Screenshot from 2022-09-20 10-47-25

@jmaassen
Copy link
Member

jmaassen commented Sep 20, 2022

The problem seems to be that the search in the RSD and ROR databases behave differently. The "University of Utrecht" doesn't seem to match any RSD entry, but ROR is smart enough to figure out that you actually mean "Utrecht University".

We should improve the search, and ensure the RSD search is as least as smart as the ROR one

@jmaassen
Copy link
Member

We have figured out a way to solve this issue. It basically comes down to this:

  • search in ROR first to get a list of potential hits
  • search in RSD with both the string and the list of ROR-IDs the ROR search has returned
  • return a de-duplicated list that prefers existing RSD entries over new ROR ones

We'll implement this an let you know when it's available.

@dmijatovic dmijatovic self-assigned this Sep 22, 2022
@ewan-escience
Copy link
Collaborator

Isn't this the same as #442?

@bakhshir
Copy link
Author

it does not give that error message.

@ewan-escience
Copy link
Collaborator

I do when I click on save, did you try that?

@bakhshir
Copy link
Author

I don't have to press save button, unless the RSD has been updated and now I have to? I am adding UU to participating organizations.

@ewan-escience
Copy link
Collaborator

I have to press save to get the same error as in #442. How do you trigger the error in #442?

I think that in both cases, the RSD database doesn't find what you're looking for, but the ROR database does, because your search string doesn't match what's in the RSD db. But since the entry with the ROR is already in the RSD database, under a slightly different name, you will get an error when trying to add the suggestion from ROR db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants