Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

442 duplicate ror organization #537

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Conversation

ewan-escience
Copy link
Collaborator

Improve ROR search

Changes proposed in this pull request:

  • When searching to add a participating/funding organisation, we first query the ROR database, then we search the RSD database, where we also query for ROR-ids found in the first search
  • The search to the RSD db does only one query for name, website and ROR-ids, not multiple queries

How to test:

  • docker-compose build --parallel && docker-compose up --scale scrapers=0
  • Login as an admin
  • If necessary, create a software and project page
  • On the sw page, add organisation by searching for Vrije Universiteit, add the Vrije Universiteit Amsterdam one from ROR.
  • Go to the Vrije Universiteit Amsterdam page, edit the name to be Free University (or something completely random if you want)
  • Go to the project page, search for Vrije Universiteit both in participating and funding organisations, the Free University entry from the RSD db should show up and the result from the ROR db should not show up

Closes #442
Closes #531

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

Copy link
Member

@jmaassen jmaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

Copy link
Contributor

@dmijatovic dmijatovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UU organization name dependency: duplicated entry? problem with duplicated ROR organization
3 participants