Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing examples pipeline due to changes in GDML material files #70

Merged
merged 43 commits into from
Oct 4, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Sep 30, 2022

jgalan Ok: 64

@jgalan jgalan requested a review from lobis October 3, 2022 06:52
@jgalan
Copy link
Member Author

jgalan commented Oct 3, 2022

Hi @lobis, what we could do with the 3 reference examples? Not sure how to proceed now.

@lobis
Copy link
Member

lobis commented Oct 3, 2022

Hi @lobis, what we could do with the 3 reference examples? Not sure how to proceed now.

I think we need to also include the materials.xml in the geometry.

instead of

<!DOCTYPE gdml [
        <!ENTITY geometry SYSTEM "geometry.gdml">
        <!ENTITY materials SYSTEM "https://sultan.unizar.es/materials/gases.xml">
        ]>

do something like

<!DOCTYPE gdml [
        <!ENTITY geometry SYSTEM "geometry.gdml">
        <!ENTITY materials SYSTEM "https://sultan.unizar.es/materials/materials.xml">
        <!ENTITY gases SYSTEM "https://sultan.unizar.es/materials/gases.xml">
        ]>

and dereference them appropriately (&gases, &materials).

Looks like this is not needed for the latest Geant4 versions but if we want to keep compatiblity with older version we may need to do this.

@lobis lobis changed the base branch from master to lobis-materials October 4, 2022 16:56
@jgalan jgalan marked this pull request as ready for review October 4, 2022 17:21
@lobis lobis merged commit 5c711eb into lobis-materials Oct 4, 2022
@jgalan jgalan deleted the fixing_examples branch October 4, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants