Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert single-use string variables to COMPOUND_STRINGs #4959

Closed
8 tasks done
fdeblasio opened this issue Jul 13, 2024 · 1 comment
Closed
8 tasks done

Convert single-use string variables to COMPOUND_STRINGs #4959

fdeblasio opened this issue Jul 13, 2024 · 1 comment
Labels
feature-request Requests a new feature

Comments

@fdeblasio
Copy link

fdeblasio commented Jul 13, 2024 •
edited
Loading

Description

From @Bassoonian in #4951

These are only used once, so I would personally be inclined to convert them to COMPOUND_STRINGs and remove them from strings.c and strings.h. The only reason they're lumped with the rest of the strings is for pret matching purposes and it just makes it harder to edit imo

I think this logic should be applied to all single-use strings

  • Berry Blender
  • PokeNav
  • Default player names
  • Mechadolls
  • PC text
  • Bag pockets
  • Berries
  • PokeBlocks

Discord contact info

Frankfurter0
@fdeblasio fdeblasio added the feature-request Requests a new feature label Jul 13, 2024
This was referenced Jul 13, 2024
Merged
Merged
@fdeblasio fdeblasio mentioned this issue Jul 25, 2024
Merged
This was referenced Sep 2, 2024
Merged
Merged
Merged
@Bassoonian
Copy link
Collaborator

8/8 tasks done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Requests a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bassoonian @fdeblasio @hedara90