Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created COMPOUND_STRINGs for default player names #5037

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

fdeblasio
Copy link

Description

As part of the effort to turn single-use strings into COMPOUND_STRINGs, the default player names were converted. This PR also moves out new game-related text to src/main_menu.c

I believe this change should work with agbcc

Issue(s) that this PR fixes

Partially fixes #4959

Discord contact info

Frankfurter0

@AlexOn1ine AlexOn1ine added this to the 1.10 milestone Jul 25, 2024
@DizzyEggg DizzyEggg merged commit 754beee into rh-hideout:upcoming Aug 8, 2024
1 check passed
@fdeblasio fdeblasio deleted the 4959-newGame branch August 9, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants