Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created PokeNav COMPOUND_STRINGS #4983

Merged
merged 9 commits into from
Aug 16, 2024

Conversation

fdeblasio
Copy link

Description

As part of the effort to turn single-use strings into COMPOUND_STRINGs, PokeNav-related strings were converted. Also cleans up unused PokeNav text

Issue(s) that this PR fixes

Partially fixes #4959

Discord contact info

Frankfurter0

@fdeblasio
Copy link
Author

Failing on agbcc. Will have to be merged after agbcc is deprecated

@mrgriffin mrgriffin added this to the 1.10 milestone Jul 16, 2024
@AlexOn1ine
Copy link
Collaborator

@fdeblasio can you solve conflicts?

@fdeblasio
Copy link
Author

@fdeblasio can you solve conflicts?

Done

@AlexOn1ine AlexOn1ine self-assigned this Aug 16, 2024
@AlexOn1ine AlexOn1ine merged commit bced2c9 into rh-hideout:upcoming Aug 16, 2024
1 check passed
@fdeblasio fdeblasio deleted the 4959-pokeNav branch August 16, 2024 20:43
@AsparagusEduardo AsparagusEduardo added type: cleanup category: overworld Pertains to out-of-battle mechanics labels Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: overworld Pertains to out-of-battle mechanics type: cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants