[battle_engine] fix multi hit/stormdrain-like interactions #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuffelSaft
requested changes
Nov 30, 2021
data/battle_scripts_1.s
Outdated
| @@ -8072,7 +8072,8 @@ BattleScript_MoveStatDrain:: | |||
| printstring STRINGID_TARGETABILITYSTATRAISE | |||
| waitmessage B_WAIT_TIME_LONG | |||
| clearsemiinvulnerablebit | |||
| tryfaintmon BS_ATTACKER, FALSE, NULL | |||
| tryfaintmon BS_ATTACKER, FALSE, NULL @ this should be removed, unless I'm missing something | |||
There was a problem hiding this comment.
This is here just for Explosion/Self Destruct, which can be changed to electric type and absorbed. I think running tryfaintmon only for those move effects would be fine, but it does need to be there or they'll glitch out.
There was a problem hiding this comment.
Interesting!
Why is it not there for volt absorb then?
There was a problem hiding this comment.
For whatever reason it was working properly with Volt Absorb IIRC, but not Lightningrod/Motor Drive.
There was a problem hiding this comment.
Added the fix for waterabsorb-like abilities, also left a comment to not wonder what's up in the future
kleeenexfeu
changed the title
kleeenexfeu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid hits passed the first one to go through storm drain (and possibly flash fire), I added the orhalfword used in water absorb battlescript.
I added comments on the lines that I think should be deleted because I don't see what purpose they serve. Following a water absorb or storm drain-like activation, the user cannot faint since rocky helmet, life orb and friends wouldn't activate. Any input is welcome :)
EDIT: doesn't fix scenario like galvanized explosion being blocked by volt absorb or motor drive in double. After volt absorb is activated, no other target will take damage. This is a bug from the battle engine, I'll see if I can fix it in this PR.