Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Explosion + Galvanize + Volt Absorb and Mind Blown #2688

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

DizzyEggg
Copy link
Collaborator

Fixes #1961

Replacement for an old PR #1975, but my fix is less invasive.
I only modified(by saving a battler) and made use of a previously unused command jumpifabilitypresent.
I simplified Explosion / Mind Blown battlescript, so it doesn't loop the targets itself, but handles the job to the moveend command.
Fixed Mind Blown, because it was always fainting the user before.

@DizzyEggg
Copy link
Collaborator Author

Added Tests for Mind Blown and updated tests for Volt Absorb, Damp and Explosion.
Ready for review

@DizzyEggg DizzyEggg requested a review from ghoulslash February 18, 2023 10:36
mrgriffin
mrgriffin previously approved these changes Feb 21, 2023
Copy link
Collaborator

@mrgriffin mrgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 all proposed changes are just small syntax tweaks

test/move_effect_mind_blown.c Outdated Show resolved Hide resolved
test/move_effect_mind_blown.c Outdated Show resolved Hide resolved
test/move_effect_mind_blown.c Outdated Show resolved Hide resolved
test/move_effect_mind_blown.c Outdated Show resolved Hide resolved
test/move_effect_mind_blown.c Outdated Show resolved Hide resolved
test/move_effect_mind_blown.c Outdated Show resolved Hide resolved
test/move_effect_explosion.c Outdated Show resolved Hide resolved
test/move_effect_explosion.c Outdated Show resolved Hide resolved
test/ability_volt_absorb.c Outdated Show resolved Hide resolved
test/ability_damp.c Outdated Show resolved Hide resolved
@mrgriffin mrgriffin merged commit d73ab02 into rh-hideout:upcoming Feb 21, 2023
@DizzyEggg DizzyEggg deleted the galvanize_explosion branch February 22, 2023 08:00
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[battle_engine]Volt absorb stops explosion from damaging other pokémon
2 participants