Fix for burn up/double shock #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
force-pushed
the
burn_up_double_shock
branch
from
2306149 to
4146f01
Compare
AsparagusEduardo
requested changes
Apr 29, 2023
|
Applied all suggestions. |
AsparagusEduardo
approved these changes
Apr 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Burn Up and Double Shock not losing the typing when a target is killed and double pp consumption when used.
/Edit: Added tests including one specific for this scenario that fails without the fix.
Images
Issue(s) that this PR fixes
Fixes #2961, Fixes #2960
Discord contact info
AlexOnline#2331