Fix some ball multiplier configs #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what does ball multiplier mean? is it like how it affects the catch rate? |
Ye. It's the modifier applied to a Poké Ball when you throw it in battle in order to catch a Pokémon. |
make senses now that you put it that way 💀 |
LOuroboros
previously approved these changes
Jan 8, 2024
AsparagusEduardo
requested changes
Jan 8, 2024
…ts in a more specific manner Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
…R and B_SAFARI_BALL_MODIFIER Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
…d_handleballthrow into a regular if/else if statement Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
AsparagusEduardo
approved these changes
Jan 8, 2024
Fervstheone
added a commit
to Fervstheone/pokeemerald-expansion
that referenced
this pull request
Jan 9, 2024
* Fix some ball multiplier configs * Updated the comment of B_LURE_BALL_MODIFIER * Specified the effects of B_LURE_BALL_MODIFIER in itsa state its effects in a more specific manner Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com> * Corrected the comments of B_DREAM_BALL_MODIFIER, B_SPORT_BALL_MODIFIER and B_SAFARI_BALL_MODIFIER Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com> * Turned the ternaries in the case for the Lure Ball's catch rate in Cmd_handleballthrow into a regular if/else if statement Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com> --------- Co-authored-by: LOuroboros <lunosouroboros@gmail.com> Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Discord contact info
bassoonian