Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicating flute bug #5436

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

ghoulslash
Copy link
Collaborator

In doubles, if you choose to use a flute item on battler 0 and then cancel, you end up with 2 flutes

@ghoulslash ghoulslash added the bugfix Bugfixes label Sep 26, 2024
@kittenchilly
Copy link

This bug might also cause issues for other infinite use items that work in battles, not just flutes

@ghoulslash
Copy link
Collaborator Author

This bug might also cause issues for other infinite use items that work in battles, not just flutes

are there others in expansion? If there's a way to check a specific field or item type that would be better than hardcoded ids

@Bassoonian
Copy link
Collaborator

I'd consider adding a field to items to indicate them not being used up, personally. Surely we have a bit left somewhere and it'd be considerably cleaner than hardcoding IDs

@kittenchilly
Copy link

This bug might also cause issues for other infinite use items that work in battles, not just flutes

are there others in expansion? If there's a way to check a specific field or item type that would be better than hardcoded ids

You can check for importance of the item (items with an importance set shouldn't be used up, like poke flute), though you'd still have to check for the colored flutes separately since they dont have an importance.

@kittenchilly
Copy link

Although I'm realizing if you have multiple of an important item from this bug, you won't notice it since it doesn't display the amount you have. Still would be worth it to fix, I think

@Bassoonian
Copy link
Collaborator

Importance can't be used for this as you implied, so a new bit would need to be used.

@Pawkkie
Copy link
Collaborator

Pawkkie commented Oct 1, 2024

In this interest of not having this PR sit here due to ambiguity, are we saying

adding a field to items to indicate them not being used up

is a requirement to merge this PR, or are we going to merge this as is (it fixes a known broken instance) and make an issue to add an item field at a later date

@kittenchilly
Copy link

I think we can just merge as is and do field stuff later, especially since it might be more invasive

@Bassoonian Bassoonian merged commit be5f2e0 into rh-hideout:master Oct 3, 2024
1 check passed
@Bassoonian Bassoonian added the category: items Pertains to items label Oct 18, 2024
@ghoulslash ghoulslash deleted the be/flutefix branch October 20, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: items Pertains to items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants