-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicating flute bug #5436
Conversation
This bug might also cause issues for other infinite use items that work in battles, not just flutes |
are there others in expansion? If there's a way to check a specific field or item type that would be better than hardcoded ids |
I'd consider adding a field to items to indicate them not being used up, personally. Surely we have a bit left somewhere and it'd be considerably cleaner than hardcoding IDs |
You can check for importance of the item (items with an importance set shouldn't be used up, like poke flute), though you'd still have to check for the colored flutes separately since they dont have an importance. |
Although I'm realizing if you have multiple of an important item from this bug, you won't notice it since it doesn't display the amount you have. Still would be worth it to fix, I think |
Importance can't be used for this as you implied, so a new bit would need to be used. |
In this interest of not having this PR sit here due to ambiguity, are we saying
is a requirement to merge this PR, or are we going to merge this as is (it fixes a known broken instance) and make an issue to add an item field at a later date |
I think we can just merge as is and do field stuff later, especially since it might be more invasive |
In doubles, if you choose to use a flute item on battler 0 and then cancel, you end up with 2 flutes