Replace hardcoded flute check with consumability check

[Bassoonian]

#5436 fixed a bug that would duplicate flutes, but introduced a hardcoded check for flutes. This PR replaces said hardcoded check with a per-item field that indicates inconsumability for items that can be used in battle.

Issue(s) that this PR fixes

Fixes #5464

Discord contact info

bassoonian

[kittenchilly]

Can you check other places where importance is checked for consumability to switch over to this system?

[kittenchilly]

Also Poke Flute needs the not consumable field set as well.

[Bassoonian]

Also Poke Flute needs the not consumable field set as well.

I personally find it a given that Key Items (read: items marked with importance and not having an amount shown in the bag) aren't consumed in battle. Why would they be Key Items/hide their number otherwise?

[AlexOn1ine]

Also Poke Flute needs the not consumable field set as well.

I personally find it a given that Key Items (read: items marked with importance and not having an amount shown in the bag) aren't consumed in battle. Why would they be Key Items/hide their number otherwise?

Since it is vanilla behavior I think it makes sense to make it none consumable even if it looks weird.

[AlexOn1ine]

Also Poke Flute needs the not consumable field set as well.

I personally find it a given that Key Items (read: items marked with importance and not having an amount shown in the bag) aren't consumed in battle. Why would they be Key Items/hide their number otherwise?

Since it is vanilla behavior I think it makes sense to make it none consumable even if it looks weird.

Also Poke Flute needs the not consumable field set as well.

So after thinking about it I don't think we need to do this because as Jasper said Key Items are already not consumed anyways.