Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add various tests, add RNG_RANDOM_TARGET #5438

Merged
merged 13 commits into from
Oct 11, 2024
Merged

Add various tests, add RNG_RANDOM_TARGET #5438

merged 13 commits into from
Oct 11, 2024

Conversation

ghoulslash
Copy link
Collaborator

@ghoulslash ghoulslash commented Sep 27, 2024 •
edited
Loading

This is kind of a running list of new tests with no particular strategy. It is not a draft but is probably a 'living' pull request. Can be merged at anytime, though.

Tests included:

  • B_BURN_DAMAGE will change the test to 1/16th or 1/8th damage accordingly
  • Add Belly Drum + Contrary Test
  • Update kings shield test with stat change value config
  • Sticky web + contrary test

Also Adds:

@ghoulslash ghoulslash added the category: battle-tests Related to the automated test environment label Sep 27, 2024
ghoulslash added 4 commits September 29, 2024 22:28
@ghoulslash ghoulslash changed the title Add various tests Add various tests, add RNG_RANDOM_TARGET Sep 30, 2024
Bassoonian
Bassoonian reviewed Oct 3, 2024
View reviewed changes
src/battle_script_commands.c Outdated Show resolved Hide resolved
src/battle_util.c Outdated Show resolved Hide resolved
test/battle/move_effect/uproar.c Outdated Show resolved Hide resolved
ghoulslash and others added 8 commits October 3, 2024 20:40
add sticky web+contrary test
4d72200
add EXPECT_EQ to contrary+sticky web test
6ecb2ef
@ghoulslash @Bassoonian
Update src/battle_script_commands.c
7cf6781 
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
@ghoulslash @Bassoonian
Update src/battle_util.c
08553b7 
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
@ghoulslash @Bassoonian
Update test/battle/move_effect/uproar.c
5915967 
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
fix test
6b578c5
Merge branch 'be/tests' of https://github.com/ghoulslash/pokeemerald …
b856bb2 
…into be/tests
syntax fix
1d5b9d8
@AlexOn1ine AlexOn1ine merged commit 353915e into rh-hideout:upcoming Oct 11, 2024
1 check passed
@ghoulslash ghoulslash deleted the be/tests branch October 20, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bassoonian Bassoonian Bassoonian left review comments

@AlexOn1ine AlexOn1ine AlexOn1ine approved these changes

Assignees
No one assigned
Labels
category: battle-tests Related to the automated test environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghoulslash @Bassoonian @AlexOn1ine