Fixed some gba sprites #5607
Fixed some gba sprites #5607
Conversation
| @@ -11433,7 +11436,7 @@ const struct SpeciesInfo gSpeciesInfoGen3[] = | |||
| .frontAnimId = ANIM_GROW_VIBRATE, | |||
| .backPic = gMonBackPic_DeoxysNormal, | |||
| .backPicSize = MON_COORDS_SIZE(64, 56), | |||
| .backPicYOffset = 6, | |||
| .backPicYOffset = P_GBA_STYLE_SPECIES_GFX ? 2 : 6, | |||
There was a problem hiding this comment.
Shouldn't this be 8 instead of 2?
(mainly cross-referencing the vanilla table https://github.com/pret/pokeemerald/blob/e45fe13af4551a080704b6a2a2ee87000c43d2b7/src/data/pokemon_graphics/enemy_mon_elevation.h#L64)
There was a problem hiding this comment.
That sprite for Deoxys-N wasn't supposed to show up at all in vanilla Emerald, the 8 was used by the back sprite of Speed Forme :)
I got the 2 by testing manually, there wasn't much I could refer to for placing the Normal form and that's why I left it alone besides the back that was easily observable (tried to look up Pokeruby's code, but the elevations there looks different from Emerald, and I couldn't find the section regarding the other placements)
AsparagusEduardo
added
bugfix
AsparagusEduardo
added
the
category: pokemon
Description
Some of the newly re-added GBA sprites had their positions (the back of Chimecho and Deoxys-N, namely) or their elevation (a few mons that float in Emerald, but their sprites in the expansion were touching the ground) wrong. This PR fixes this.
Feature(s) this PR does NOT handle:
For Deoxys, I fixed the position of its back sprite, but i didn't address some other things going on with it: namely, the front sprite that flip flops between Normal and Speed form and the icons that were not updated for its other forms (Gen 6+ icons were not added for them)
Discord contact info
subzeroeclipse