bootloader: Create an installation task for collecting kernel arguments #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the implementation to the `InstallBootloaderTask` class.
Add a new method for collecting kernel arguments for the installation.
poncovka
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
Use the `CollectKernelArgumentsTask` task to collect kernel arguments for the installation. It will be used by the bootupd support that needs to be able to collect kernel arguments without installing the bootloader.
poncovka
force-pushed
the
master-kernel_arguments_task
branch
from
8fda2a2
to
8a7641e
Compare
poncovka
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
|
/kickstart-test -t bootloader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
CollectKernelArgumentsTasktask to collect kernel argumentsfor the installation. This will be used by the
bootupdsupport that needsto be able to collect kernel arguments without installing the bootloader.
See: #5298 (comment)).