-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic bootupd support #5342
Automatic bootupd support #5342
Conversation
Hello @VladimirSlavik! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: Comment last updated at 2023-11-29 15:04:09 UTC |
@VladimirSlavik This seems to fix the issue with kickstart partitioning on multiple disks: storaged-project/blivet#1174 |
6a311c4
to
b4076d4
Compare
/kickstart-test --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work. Thanks a lot for this!
b4076d4
to
7daf79e
Compare
/kickstart-test --testtype smoke |
This pull request will be rebased on top of #5350 to enable collection and configuration of the kernel arguments during the installation with the bootupd bootloader. See #5298 (comment) for more information. |
7daf79e
to
6d4c4b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, it looks good to me. Thank you!
Original commit message from Colin Walters was: The https://github.com/coreos/bootupd project was created to fill the gap in bootloader management for ostree-based systems. When it was created, it was just integrated into Fedora CoreOS and derivatives; this left the Atomic Desktops (Silverblue etc.) as unfixed, and it was never used by RHEL for Edge. This PR is aiming to circle back and close that gap. We detect if bootupd is in the target root; if it is, then we skip the regular bootloader work, and just run bootupd to perform the installation. The other hacks we have around the grub config are no longer necessary in this mode.
6d4c4b5
to
af31179
Compare
/kickstart-test --testtype smoke |
/kickstart-test --testtype bootloader |
I think this might be it... |
/kickstart-test rpm-ostree-container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
Awesome, thanks! Looking forward to trying this out once there's a built ISO in rawhide/ELN. |
🎉 Thanks for the work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great solution, thanks for working on this!
Nice work @poncovka and @VladimirSlavik ! |
Followup in #5363 |
Another followup item I just noticed CentOS/centos-bootc#97 which may or may not need Anaconda work, will consider |
The kickstart file works with a Fedora 40+ (or ELN) installer ISO as it requires rhinstaller/anaconda#5342. Co-authored-by: Colin Walters <walters@verbum.org>
The kickstart file works with a Fedora 40+ (or ELN) installer ISO as it requires rhinstaller/anaconda#5342. Co-authored-by: Colin Walters <walters@verbum.org>
It seems to work, mostly. Needs explicit partitioning in kickstart.
Replaces #5298 which has initial discussion.
TODOs: