Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦠 ocp 4.11 deploy 🦠 #147

Merged
merged 23 commits into from
Nov 16, 2022
Merged

🦠 ocp 4.11 deploy 🦠 #147

merged 23 commits into from
Nov 16, 2022

Conversation

eformat
Copy link
Member

@eformat eformat commented Aug 27, 2022

Deploy TL500 to OpenShift 4.11

I have added new values-v4.11.yaml files and config that has the extra config for DevSpaces

so all you have to do for 4.11 is use those files (the default values.yaml is still read) when deploying the charts (README has also been updated to reflect this)

@eformat
Copy link
Member Author

eformat commented Aug 27, 2022

the only breaking change appears to be CRW -> devspaces Operator renaming

-- PodSecurity "restricted:v1.24"
-- https://connect.redhat.com/en/blog/important-openshift-changes-pod-security-standards

Changes to PSP brings up the following would violate PodSecurity "restricted:v1.24 warnings

(1) ldap group sync

~/git/openshift-management ⎇ master#edf0e91$ helm upgrade cronjob-ldap-group-sync ...
Release "cronjob-ldap-group-sync" does not exist. Installing it now.
W0827 13:13:31.916574 1084014 warnings.go:70] batch/v1beta1 CronJob is deprecated in v1.21+, unavailable in v1.25+; use batch/v1 CronJob
W0827 13:13:32.276515 1084014 warnings.go:70] batch/v1beta1 CronJob is deprecated in v1.21+, unavailable in v1.25+; use batch/v1 CronJob
W0827 13:13:32.276552 1084014 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "cronjob-ldap-group-sync" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "cronjob-ldap-group-sync" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "cronjob-ldap-group-sync" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "cronjob-ldap-group-sync" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
NAME: cronjob-ldap-group-sync
LAST DEPLOYED: Sat Aug 27 13:13:31 2022
NAMESPACE: cluster-ops
STATUS: deployed
REVISION: 1
TEST SUITE: None

(2) tl500-base chart

tl500-base ⎇ main#2c40a76 $ helm upgrade --install tl500-base . \
        --namespace tl500 --create-namespace --timeout=20m
Release "tl500-base" does not exist. Installing it now.
W0827 13:15:09.349655 1085985 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "job" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "job" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "job" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "job" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
W0827 13:15:17.326350 1085985 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "controller" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "controller" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "controller" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "controller" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
W0827 13:15:17.343673 1085985 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "tl500-teamsters" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "tl500-teamsters" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "tl500-teamsters" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "tl500-teamsters" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
W0827 13:15:18.666634 1085985 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "crd-check" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "crd-check" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "crd-check" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "crd-check" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

@eformat
Copy link
Member Author

eformat commented Aug 27, 2022

Teamsters regression Testing Looks Good

create-ateam create  -> success
create-ateam create Tests run: 9
create-ateam create Failed tests: 0
create-ateam create All tests passed.

@ckavili
Copy link
Contributor

ckavili commented Aug 29, 2022

I ❤️ Teamster

@eformat eformat marked this pull request as ready for review November 9, 2022 22:22
@eformat
Copy link
Member Author

eformat commented Nov 9, 2022

Related: rht-labs/tech-exercise#232

@eformat
Copy link
Member Author

eformat commented Nov 12, 2022

I have adjusted values-4.11.yaml to work with base values.yaml files as both are evaluated by helm when you want 4.11 deployment:

helm upgrade --install tl500-base -f values-v4.11.yaml . --namespace tl500 --create-namespace 
helm upgrade --install tl500-course-content -f values-v411.yaml . --namespace tl500 --create-namespace

@jfilipcz
Copy link
Contributor

One small thing, what happened with tooling/charts/tl500-base/templates/gitlab/deployments.yaml ?

@eformat
Copy link
Member Author

eformat commented Nov 14, 2022

One small thing, what happened with tooling/charts/tl500-base/templates/gitlab/deployments.yaml ?

LOLZ ! i deleted it ;) thanx .. yeah my mistake, reverted it. its the only file that fails when doing helm template cause of the ldap injection

Copy link
Contributor

@jfilipcz jfilipcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👹 👹

@eformat
Copy link
Member Author

eformat commented Nov 16, 2022

OK i am gonna merge this and convert RHPDS to 4.11 as the test bed ...

@eformat eformat merged commit 3247159 into rht-labs:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants