🧪devfile migrated to v2.1.0🧪 #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And I guess this should go hand in hand with #147 🙈 |
|
yeah .. also included in #147 which has all the changes for 4.11 ... so could close this since its a subset ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes on devspaces and the following error on OpenShift 4.11, devfile is migrated to v2.1.0.
However, I am not sure if this devfile would work on OpenShift 4.10 or before. I don't have an OpenShift 4.10 to try at the moment 🫣🫣 If it works, it is good! But since in tech-exercise documentation, we are directly pointing to main devfile, maybe we need to hold this to merge?
Should we update tech-exercise to point to a specific version? I am not sure if everyone is going to run TL500 on OpenShift 4.11 🤷🏻♀️ What do you think @eformat @springdo? 👀