Patch/Bug fix for ContextMenuMouseListener Actions #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undid-Iridium
commented
Dec 3, 2023
| tasks.jacocoTestReport { | ||
| dependsOn(tasks.test) // tests are required to run before generating the report | ||
| reports { | ||
| xml.required.set(false) | ||
| csv.required.set(false) | ||
| html.outputLocation.set(file("${layout.buildDirectory}/jacocoHtml")) |
There was a problem hiding this comment.
Fixes (at least on windows) this build output during gradle test/testAll
Undid-Iridium
commented
Dec 3, 2023
| // Use CompletableFuture to run setup() asynchronously | ||
| CompletableFuture<Void> setupFuture = CompletableFuture.runAsync(() -> { | ||
| try { | ||
| ripper.setup(); |
There was a problem hiding this comment.
This test unit would take forever, and still fail on my machine. I didn't want to modify any behaviors other than just giving up after X time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
Fixes issue with copy/pasting. Fixes right click context menu. Fixes pasting >96 characters and the UI growing to that size.
FYI: I've never touched any of these libraries before so this is mostly googling/etc for the last few hours. I probably need to fix the junits (they run but I am not 100% convinced they do what I actually want).
My Branch
Main
Testing
Required verification:
mvn test(there are no new failures or errors). -> gradle test, maven isn't used (Unless I am blind)Optional but recommended: