Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Imgur ripper #203

Merged
merged 10 commits into from
Nov 3, 2024
Merged

Fix Imgur ripper #203

merged 10 commits into from
Nov 3, 2024

Conversation

Tush-r
Copy link

@Tush-r Tush-r commented Sep 12, 2024

Java version

openjdk version "21.0.4" 2024-07-16
OpenJDK Runtime Environment (build 21.0.4+7-Ubuntu-1ubuntu220.04)
OpenJDK 64-Bit Server VM (build 21.0.4+7-Ubuntu-1ubuntu220.04, mixed mode, sharing)

Check for regression


Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

  • Fix imgur ripper for galleries, single images and user accounts.
  • Add support for new gallery and user URLs. Regex101 can be used to dissect the new regex.
  • Remove unsupported series of images code.
  • Replace imgur's usage of AlbumRipper with AbstractHTMLRipper.
  • Deprecate AlbumRipper.
  • Fix imgur prefixing for albums.
  • Fix imgur subfolder creation for user albums.
  • Add tests for new URLs.
  • Remove 96 char limit for pasted URLs as it is not reproducible anymore.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@Tush-r Tush-r marked this pull request as ready for review September 21, 2024 11:56
@soloturn soloturn merged commit 5d7897d into ripmeapp2:main Nov 3, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer downloading from Imgur
2 participants